DWR

Regression in util.js breaks dwr.util.addOptions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.1
  • Fix Version/s: 2.0.2
  • Component/s: Util
  • Description:
    Hide
    A regression in util.js between versions 1.48 and 1.49 has broken dwr.util.addOptions(). In version 1.48 and prior, the line

    if (typeof data[prop] != "function") {

    was there, preventing adding options that were functions (like the extend function from Prototype). In 1.49, that check was taken out and is causing problems. Is there any chance of adding that back in?
    Show
    A regression in util.js between versions 1.48 and 1.49 has broken dwr.util.addOptions(). In version 1.48 and prior, the line if (typeof data[prop] != "function") { was there, preventing adding options that were functions (like the extend function from Prototype). In 1.49, that check was taken out and is causing problems. Is there any chance of adding that back in?

Activity

Hide
Mike Wilson added a comment - 02/May/07 5:13 PM

This is an easy fix. I suggest I fix it both in HEAD (2.1) and Branch_2_0 (2.0.2).
Any comments?

Show
Mike Wilson added a comment - 02/May/07 5:13 PM This is an easy fix. I suggest I fix it both in HEAD (2.1) and Branch_2_0 (2.0.2). Any comments?
Hide
Scott Rankin added a comment - 02/May/07 5:16 PM

I'd love it if it got fixed in 2.0.2 - that would mean we could get off of RC4 and onto a released version.

Show
Scott Rankin added a comment - 02/May/07 5:16 PM I'd love it if it got fixed in 2.0.2 - that would mean we could get off of RC4 and onto a released version.
Hide
Mike Wilson added a comment - 10/May/07 12:48 PM

Checked in fix. Please have a go and try it if you have access to CVS.

Show
Mike Wilson added a comment - 10/May/07 12:48 PM Checked in fix. Please have a go and try it if you have access to CVS.

People

Dates

  • Created:
    02/May/07 3:07 PM
    Updated:
    19/Feb/10 8:31 AM
    Resolved:
    10/May/07 12:48 PM