DWR

A timeout with id 0 is not cleared

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6
  • Fix Version/s: 2.0.7, 3.0.RC2
  • Component/s: Engine
  • Documentation Required:
    No
  • Description:
    Hide
    This is a classic 0 vs. null bug which only manifests in environments where timeouts have integer IDs counting from 0. I've observed this on 2.0.5 and none of the issues closed for 2.0.6 seem to address this, so here is a tiny diff:

    @@ -1024,7 +1024,7 @@
       }

       // Timeout tidyup
    - if (batch.timeoutId) {
    + if (batch.timeoutId != null) {
         clearTimeout(batch.timeoutId);
         delete batch.timeoutId;
       }
    Show
    This is a classic 0 vs. null bug which only manifests in environments where timeouts have integer IDs counting from 0. I've observed this on 2.0.5 and none of the issues closed for 2.0.6 seem to address this, so here is a tiny diff: @@ -1024,7 +1024,7 @@    }    // Timeout tidyup - if (batch.timeoutId) { + if (batch.timeoutId != null) {      clearTimeout(batch.timeoutId);      delete batch.timeoutId;    }

Activity

Hide
David Marginian added a comment - 08/Feb/10 5:46 AM

I have just fixed this for 3.x and 2.x. You can check our CI site for the next build: http://ci.directwebremoting.org/bamboo/. I am going to wait to resolve this because I need to determine what to do with versioning.

Show
David Marginian added a comment - 08/Feb/10 5:46 AM I have just fixed this for 3.x and 2.x. You can check our CI site for the next build: http://ci.directwebremoting.org/bamboo/. I am going to wait to resolve this because I need to determine what to do with versioning.
Hide
Mike Wilson added a comment - 18/Feb/10 1:10 AM

Thanks for finding this, Logi!
David: we might as well plan for a 2.0.7 and use that as "Fix version"?

Show
Mike Wilson added a comment - 18/Feb/10 1:10 AM Thanks for finding this, Logi! David: we might as well plan for a 2.0.7 and use that as "Fix version"?

People

Dates

  • Created:
    08/Feb/10 3:15 AM
    Updated:
    06/Aug/10 9:03 PM
    Resolved:
    06/Aug/10 9:03 PM